lib: runtime deprecate SlowBuffer #55175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
RafaelGSS
force-pushed
the
runtime-deprecate-slow-buffer
branch
from
fd4ffe7
to
b409b7e
Compare
RafaelGSS
added
the
semver-major
|
Tagging @nodejs/tsc as it's a semver-major that might land on Node.js 23. |
RedYetiDev
reviewed
Sep 30, 2024
anonrig
approved these changes
Sep 30, 2024
RedYetiDev
added
author ready
ronag
approved these changes
Sep 30, 2024
github-actions
bot
removed
the
request-ci
RedYetiDev
reviewed
Sep 30, 2024
BridgeAR
requested changes
Sep 30, 2024
|
CITGM: https://ci.nodejs.org/job/citgm-smoker/3478/ |
|
CITGM results: But, looking at those errors, it doesn't seem related to this change, but to the |
It seems ok to land on |
|
@RafaelGSS could you please add a test for the deprecation? We have a couple of tests like that. Otherwise it's fine to land |
@BridgeAR PTAL. I will do the last sync for v23 today and I'd like to have it included |
github-actions
bot
removed
the
request-ci
RafaelGSS
force-pushed
the
runtime-deprecate-slow-buffer
branch
from
1817d2d
to
446244a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55175 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 652 652
Lines 186864 186868 +4
Branches 36064 36061 -3
=======================================
+ Hits 165217 165225 +8
+ Misses 14888 14887 -1
+ Partials 6759 6756 -3
|
|
I'm not sure why lint is complaining. I'm not changing the files this is mentioning. Also, it doesn't fail locally. Can it be related to lint cache? |
Since you pushed today, I suspect something has landed on main that has broken the linter -- maybe a conflict/race between something that changed the rules and a something else that didn't have those rules when it had its CI run? |
Looks like it was this PR #54160 |
RafaelGSS
force-pushed
the
runtime-deprecate-slow-buffer
branch
from
446244a
to
0a56956
Compare
BridgeAR
approved these changes
Oct 14, 2024
github-actions
bot
removed
the
request-ci
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 019efe1 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55175 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlowBuffer has been doc-deprecated for a while and I couldn't find why we didn't want to proceed with the deprecation cycle on this feature. Therefore, this PR runtime deprecates SlowBuffer.